Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix root logger handler #228

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[Bug] Fix root logger handler #228

merged 3 commits into from
Nov 29, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Nov 28, 2023 •
edited
Loading

Why

What

  • Instead of adding RichHandler to root logging, now it is being added to SDK specific loggers

Tests

  • Added test_misc.py for the same

image

@sainivedh sainivedh marked this pull request as ready for review November 28, 2023 08:00
isaac-chung
isaac-chung reviewed Nov 28, 2023
View reviewed changes
clarifai/utils/logging.py Show resolved Hide resolved
clarifai/utils/logging.py Outdated Show resolved Hide resolved
clarifai/utils/logging.py Outdated Show resolved Hide resolved
@sainivedh sainivedh merged commit ed305c8 into master Nov 29, 2023
6 checks passed
@sainivedh sainivedh deleted the fix-root-logger-handler branch November 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaychelliah sanjaychelliah sanjaychelliah approved these changes

@isaac-chung isaac-chung isaac-chung approved these changes

@ackizilkale ackizilkale Awaiting requested review from ackizilkale

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handler added to root logger
3 participants
@sainivedh @isaac-chung @sanjaychelliah